Piglin Barter Fix #7046
Open
Piglin Barter Fix #7046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
approved these changes
Sep 6, 2024
Removed the 'send'
|
Pretty sure renaming that file breaks tests, you should undo that |
|
Interesting, I didnt rename the file |
|
Oh wait this is feature |
|
@sovdeeth Wait, what nonsense are you talking about? lol |
No clue how the file got renamed Took out the version checking stuff
Removed version checking and needing to load/unload the actual test skript
Thanks IntelliJ
Moderocky
approved these changes
Sep 7, 2024
sovdeeth
requested changes
Sep 7, 2024
sovdeeth
added
the
bug
Efnilite
approved these changes
Sep 10, 2024
sovdeeth
approved these changes
Sep 13, 2024
sovdeeth
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the piglin barter test failing JUnit locally on Windows.
(feature branch as the patch branch does not contain it)
Target Minecraft Versions: any
Requirements: none
Related Issues: none