Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Radius Markers] Default missing fields on import to their default values on add #40

Open
Raitab opened this issue Nov 14, 2023 · 1 comment
Labels
radius markers Radius Markers plugin

Comments

@Raitab
Copy link

Raitab commented Nov 14, 2023

Something of a nit and weird use-case, but functionality I would appreciate.
I was trying to copy some markers I had, but change the npc ids, but because the id was the same as one that already existed, I couldn't. I tried erasing the id and importing it that way, but there wasn't a log to tell me why it failed. Eventually I pulled down the project and saw that markers are invalid if basically any fields are empty. I didn't want to manually grab the current epoch time or set a random integer for the markers, so I decided to create new markers instead.

I think this could be better, and would let people who are savvy share shorter json strings for imports. If you wanted, it could also let you export less data (delete the attributes for things that aren't visible, for example), then default the data on import and hide all defaulted markers.

@Skretzo
Copy link
Owner

Skretzo commented Nov 14, 2023

markers are invalid if basically any fields are empty

I have no idea why I did it that way, and I am currently working on a redesign of the plugin that has already removed that restriction.

If you wanted, it could also let you export less data (delete the attributes for things that aren't visible, for example), then default the data on import and hide all defaulted markers

This idea is actually already part of the planned redesign. I guess a consequence of this will be that markers copied from another person might look different (e.g. different default colours), but shorter export/import json string is favourable.

I didn't want to manually grab the current epoch time or set a random integer for the markers, so I decided to create new markers instead

Manually increasing/decreasing the marker id by a few numbers is perfectly fine.

@Skretzo Skretzo added the radius markers Radius Markers plugin label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
radius markers Radius Markers plugin
Projects
None yet
Development

No branches or pull requests

2 participants