Fix RenderLayers.getBlockLayer returning solid for everything #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Su5eD
reviewed
Oct 30, 2023
...v1/src/client/java/net/fabricmc/fabric/impl/blockrenderlayer/ExtendedChunkRenderTypeSet.java
Show resolved
Hide resolved
Su5eD
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forge does not populate the
BLOCKSmap inRenderLayers. This means thatRenderLayers.getBlockLayerreturns solid for any modded block. Evidently, Forge expects modders to be using the newRenderLayers.getRenderLayersfunction they patch in, however, Fabric mods will all be usinggetBlockLayersince that is correct for vanilla. Hence, we need to provide a reasonable fallback.The approach I used is to return the first render type in the
ChunkRenderTypeSet; this will work correctly on most blocks. It's quite a bit of a kludge, but better than nothing. The mixin onChunkRenderTypeSetis necessary to avoid an iterator allocation on every call.