Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpole Forge Model API with FRAPI #32

Open
Lolothepro opened this issue Aug 26, 2023 · 2 comments
Open

Interpole Forge Model API with FRAPI #32

Lolothepro opened this issue Aug 26, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Lolothepro
Copy link

Lolothepro commented Aug 26, 2023 •
edited
Loading

No description provided.

@Su5eD Su5eD added the enhancement New feature or request label Aug 28, 2023
@Su5eD
Copy link
Member

Su5eD commented Sep 23, 2023

Can you please provide which APIs exactly should be bridged?

@Lolothepro
Copy link
Author

Lolothepro commented Sep 23, 2023 •
edited
Loading

Forge's getModelData and getQuads does not default to Fabric emitBlockQuads and vice versa
For example, Continuity only uses emitBlockQuads and calls emitBlockQuads on the wrapped model. If the wrapped model is a Forge model that uses getQuads + getModelData, the emitBlockQuads call on the wrapped model will not work well. The other way around also applies, for example if a Forge model wraps a Fabric model.

Pepper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Su5eD @Lolothepro