Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smooth lighting seems broken with FFAPI, unlike FAPI #31

Closed
Lolothepro opened this issue Aug 26, 2023 · 5 comments
Closed

Smooth lighting seems broken with FFAPI, unlike FAPI #31

Lolothepro opened this issue Aug 26, 2023 · 5 comments
Labels
not us This issue is not caused by FFAPI

Comments

@Lolothepro
Copy link

Describe the bug

Indigo's fix for bug MC-197497 may be partially broken

Steps to reproduce

Go to a world with the "-465591111666617428" generation seed
Go here: /execute in minecraft:overworld run tp @s 1732.17 -13.58 -463.76 -32.13 64.95

Fabric API:
2023-08-26_13 57 25

Forgified Fabric API:
2023-08-26_13 54 11

Logs

No response

Additional context

No response
@Lolothepro Lolothepro added the bug Something isn't working label Aug 26, 2023
@Su5eD
Copy link
Member

Su5eD commented Aug 28, 2023

Looks to happen on plain Forge, too.

@Lolothepro
Copy link
Author

caused by 690539c

@Su5eD
Copy link
Member

Su5eD commented Aug 28, 2023

Yeah I remember indigo being a significant compat problem for forge mods.

@Lolothepro
Copy link
Author

Lolothepro commented Aug 28, 2023 •
edited
Loading

Yeah I remember indigo being a significant compat problem for forge mods.

Why? (do you have any examples?)

@Su5eD Su5eD removed the bug Something isn't working label Sep 17, 2023
@Su5eD
Copy link
Member

Su5eD commented Sep 23, 2023

I've thought about this, and since the bug comes from vanilla, it should be fixed by mojang or forge. FFAPI's renderer does not override forge's one to prevent mod compat issues, and trying to fix issues by mixing into forge might come with unwanted side effects.

@Su5eD Su5eD closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2023
@Su5eD Su5eD added the not us This issue is not caused by FFAPI label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not us This issue is not caused by FFAPI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Su5eD @Lolothepro