Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1] Use real topic id #8332

Open
wants to merge 2 commits into
base: release-2.1
Choose a base branch
from

Conversation

sbulen
Copy link
Contributor

@sbulen sbulen commented Oct 25, 2024

Partial for #7870

This addresses 2.1, but not 3.0.

Signed by Shawn Bulen, [email protected]
@sbulen sbulen changed the title Use real topic id [2.1] Use real topic id Oct 25, 2024
@sbulen sbulen marked this pull request as ready for review October 25, 2024 05:40
@sbulen sbulen marked this pull request as draft October 25, 2024 15:45
Signed by Shawn Bulen, [email protected]
@sbulen sbulen marked this pull request as ready for review October 25, 2024 16:25
@sbulen
Copy link
Contributor Author

sbulen commented Oct 25, 2024

Did some additional testing to ensure unapproved messages were not displayed to users - & that works. All good.

@sbulen
Copy link
Contributor Author

sbulen commented Oct 29, 2024

I'm kinda shocked how big the hole is here...

I'd recommend this for 2.1.6, if not 2.1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants