Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel Internal Interface flow typed #62

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Channel Internal Interface flow typed #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9912b9c
Updates development dependencies
beaucollins Feb 22, 2018
7ad2700
Adds flowtype to Channel module. Fixes type errors
beaucollins Feb 22, 2018
bc0498f
eslint and flow errors fail tests
beaucollins Feb 22, 2018
b7a638d
Removes outdated TODO statements
beaucollins Feb 22, 2018
d353c65
Merge remote-tracking branch 'origin/master' into cleanup/channel-int…
beaucollins Feb 28, 2018
a7d2295
Adding types and fixing type errors
beaucollins Feb 28, 2018
edc3d32
Prevent flow from failing builds
beaucollins Feb 28, 2018
fb3cb6f
Moves definitions to fix lint errors
beaucollins Feb 28, 2018
f462d8f
Moves type definiton below relevant comment
beaucollins Feb 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .flowconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
[ignore]

[include]
src/

[libs]

Expand Down
6 changes: 4 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
language: node_js
sudo: false
script:
# Enable flow to have flow errors fail the build
# - npm -s run flow
# lint errors fail the build
- npm run lint
- npm -s run lint
# unit tests with coverage report
- npm run test:coverage
- npm -s run test:coverage
node_js:
- '8'
- '7'
Expand Down
91 changes: 69 additions & 22 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"babel-preset-env": "^1.6.1",
"babel-preset-flow": "^6.23.0",
"eslint": "^4.17.0",
"flow-bin": "^0.66.0",
"mocha": "^5.0.0",
"nyc": "^11.4.1"
}
Expand Down
Loading