Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON files failing download on 2.0 themes #1015

Open
victor-roswell opened this issue Jun 20, 2024 · 0 comments
Open

JSON files failing download on 2.0 themes #1015

victor-roswell opened this issue Jun 20, 2024 · 0 comments

Comments

@victor-roswell
Copy link

victor-roswell commented Jun 20, 2024

Describe the bug

There is a bug where theme download is not downloading any of the .json files correctly. Issue seemed to have happened overnight. The problem is present in json files that have the following warning autogenerated inside the json file via shopify. The warning can not be deleted and is auto injected by shopify.

/*
* ------------------------------------------------------------
* IMPORTANT: The contents of this file are auto-generated.
*
* This file may be updated by the Shopify admin language editor
* or related systems. Please exercise caution as any changes
* made to this file may be overwritten.
* ------------------------------------------------------------
*/

To Reproduce

Steps to reproduce the behavior:

  1. Run command theme download -e your_config_dev_env_name
  2. Seems to only be an issue on 2.0 themes with the warning comment mentioned above

Expected behavior

All theme files from the defined environment should download to your local machine

Environment

Information Value
OS version macOS 13.2.1
Themekit version ThemeKit 1.3.2 darwin/amd64
Editor VSCode / Terminal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant