Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skeleton] Make cart banner optimistic #2502

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

frontsideair
Copy link

WHY are these changes introduced?

While the cart sidebar is optimistic, the banner isn't, which is inconsistent

WHAT is this pull request doing?

It makes the cart banner count optimistic

HOW to test your changes?

  1. Add something to cart
  2. Quickly close the cart sidebar
  3. Cart banner should show 1
  4. Reopen the cart sidebar
  5. Delete the line item
  6. Cart banner should show 0

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

@scottdixon scottdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another contribution @frontsideair! Subtle but important piece of the UX 🙌 Left a few comments.

templates/skeleton/app/components/Header.tsx Outdated Show resolved Hide resolved
templates/skeleton/app/components/Header.tsx Outdated Show resolved Hide resolved
templates/skeleton/app/components/Header.tsx Outdated Show resolved Hide resolved
@frontsideair
Copy link
Author

Thanks for the review! I made the changes, except my note about totalQuantity.

@frontsideair
Copy link
Author

@scottdixon can I ping you on this, if you have the bandwidth? Also for #2503 and #2506

Copy link
Contributor

@scottdixon scottdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @frontsideair!

Left a couple of comments and ccing @wizardlyhel for a second set of eyes 🙏

templates/skeleton/app/components/Header.tsx Outdated Show resolved Hide resolved
templates/skeleton/app/components/Header.tsx Outdated Show resolved Hide resolved
@frontsideair
Copy link
Author

@scottdixon thanks for the review, sent a fix just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants