-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Picture Component #115
Comments
<Picture
width="100%"
{...props}>
<Source
src={data.src}
aspectRatio="4/5"
sizes="100vw"
media="(min-width: 30em)" />
<Image
src={data.src}
aspectRatio="2/3"
sizes="100vw"
media="(min-width: 45em)" />
<Image
src={data.src}
aspectRatio="1/1"
sizes="100vw" />
</Picture> A DX similar to this would be ideal. We should also have |
I'd also be curious to take the opportunity to look at a CSS-only blurhash; which @frehner proposed previously. This looked pretty interesting to me: https://joebell.co.uk/blog/loading-images-with-the-blur-down-technique. Or at very least, provide an example for it. |
Draft implementation of focal point: #2139 |
Reviving this image — We ideally need:
This also needs to all work within a single component and be automatic for you. We would support We'd also make it possible for above the fold images to be automatically preloaded, so we can render faster, as is in #2061 — in a dream world you'd just do |
Motivation
Right now we are pulling in 1 media asset for a product or collection across small/medium/large screens. This 1 asset with no focal point can lead to bad cropping.
See decapitated snowboarder
Opportunity
Brainstorm features & functionality:
The text was updated successfully, but these errors were encountered: