Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picture: Remove new_unchecked() #468

Open
Serial-ATA opened this issue Oct 12, 2024 · 0 comments
Open

Picture: Remove new_unchecked() #468

Serial-ATA opened this issue Oct 12, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone
0.22.0

Comments

@Serial-ATA
Copy link
Owner

For Matroska compatibility in #218, another field was added to Picture (file_name). At this point, there are too many arguments for Picture::new_unchecked(). The builder pattern would be better.
@Serial-ATA Serial-ATA added the enhancement New feature or request label Oct 12, 2024
@Serial-ATA Serial-ATA added this to the 0.22.0 milestone Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.22.0
Development

No branches or pull requests
1 participant
@Serial-ATA