Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for keep and display logs #8

Open
SergiuToporjinschi opened this issue Dec 17, 2018 · 5 comments
Open

Add option for keep and display logs #8

SergiuToporjinschi opened this issue Dec 17, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@SergiuToporjinschi
Copy link
Owner

Optionally the user should be able to see the a log when on and off was emitted

@SergiuToporjinschi SergiuToporjinschi added the enhancement New feature or request label Dec 17, 2018
@zoltantakacshu
Copy link

Hi Sergiu,

I see in the latest release the changes are logged and even shown in the output. Additionally a new icon appeared in the UI "logs" - what I couldn't figure it out how is it working ...
How the UI part supposed to be working ?
What is the number of changes kept in the logs ?
Wouldn't be better if the logs would be sent in a different node output than the standard one ? (Just an idea - still trying come up with the best use of this - as previously I was logging the changes and the heat states into a chart to allow me to review the history of the heating)
Anyway - thanks ! Great work, I really love the controller.

@SergiuToporjinschi
Copy link
Owner Author

@zoltantakacshu can you see the button? this is not finished yet :) that button supposed to be not visible yet :). I wanted to create a dialog to display the logs but unfortunately is not possible without hacks so I'm planing to output as node message.

@zoltantakacshu
Copy link

Yes, the button is visible if there are logs collected... And the logs are already in the the node output as well...
:)

@SergiuToporjinschi
Copy link
Owner Author

SergiuToporjinschi commented Feb 3, 2020

yes I've tested now and I can see that, but I think I should output this as different message and not attached to the standard output
"What is the number of changes kept in the logs ?": It will be configurable;
"Wouldn't be better if the logs would be sent in a different node output than the standard one ?" will be a different output

@zoltantakacshu
Copy link

Great. the separate node output will help to build a chart based on the measured and set temperature.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants