Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xByPartition argument order #8

Open
ijxy opened this issue Dec 12, 2018 · 0 comments
Open

xByPartition argument order #8

ijxy opened this issue Dec 12, 2018 · 0 comments

Comments

@ijxy
Copy link

ijxy commented Dec 12, 2018

The proposed signature is

xByPartition(bytes32 _partition, <usual args for x>)

but this feels unintuitive because it should build on x, i.e., it is x with an extra argument to specify a parttion. Hence I would instead propose

xByPartition(<usual args for x>, bytes32 _parttion)

Although the above is explicitly targeted at the xByPartition functions, it applies equally to any functions that follow the xByY. So, generally, I am suggesting: xByY(<usual x args>, <y specific args>).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant