Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP1594 - Different return values for canTransfer and canTransferFrom #23

Open
cleanunicorn opened this issue Apr 16, 2019 · 0 comments

Comments

@cleanunicorn
Copy link

cleanunicorn commented Apr 16, 2019

The EIP spec defines the 2 functions, each one returning 2 values:
https://github.com/SecurityTokenStandard/EIP-Spec/blob/master/eip/eip-1594.md#cantransfer--cantransferfrom

function canTransfer(address _to, uint256 _value, bytes _data) external view returns (byte, bytes32);
function canTransferFrom(address _from, address _to, uint256 _value, bytes _data) external view returns (byte, bytes32);

But the implementation returns 3 values:

// Transfer Validity
function canTransfer(address _to, uint256 _value, bytes _data) external view returns (bool, byte, bytes32);
function canTransferFrom(address _from, address _to, uint256 _value, bytes _data) external view returns (bool, byte, bytes32);

function canTransfer(address _to, uint256 _value, bytes _data) external view returns (bool, byte, bytes32) {

function canTransferFrom(address _from, address _to, uint256 _value, bytes _data) external view returns (bool, byte, bytes32) {

If the implementation is correct, the EIP spec should be updated to reflect the truth.
ethereum/EIPs#1594

@cleanunicorn cleanunicorn changed the title Different returns for canTransfer and canTransferFrom Different return values for canTransfer and canTransferFrom Apr 16, 2019
@cleanunicorn cleanunicorn changed the title Different return values for canTransfer and canTransferFrom Different return values for canTransfer and canTransferFrom Apr 16, 2019
@cleanunicorn cleanunicorn changed the title Different return values for canTransfer and canTransferFrom Different return values for canTransfer and canTransferFrom Apr 16, 2019
@cleanunicorn cleanunicorn changed the title Different return values for canTransfer and canTransferFrom EIP1594 - Different return values for canTransfer and canTransferFrom Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant