Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAServerAdaptor>>#handlePadding: needed anymore ? #1396

Open
Noschvie opened this issue Dec 18, 2023 · 1 comment
Open

WAServerAdaptor>>#handlePadding: needed anymore ? #1396

Noschvie opened this issue Dec 18, 2023 · 1 comment

Comments

@Noschvie
Copy link

Hello

WAServerAdaptor>>#handlePadding:
"If you create an error page that's too small, Microsoft Internet Explorer will display its own error page that includes a link to the MSN network search engine rather than your own error page.
See http://www.404-error-page.com/404-error-page-too-short-problem-microsoft-ie.shtml for details."

^(size < 512 and: [ #(400 403 404 405 406 408 409 410 500 501 505) includes: aRequestContext response status ])
	ifTrue: [ aRequestContext response nextPutAll: ((String new: 512 - size) atAllPut: $ ) ]

is this padding needed anymore ?
Thanks, Norbert

@adriaon
Copy link

adriaon commented Dec 20, 2023

I just checked and Edge still shows its own error page without padding.

However, we are no longer padding the response. I don't remember exactly why we made this change, but the comment we added reads "not desirable for REST API's and AJAX".

Cheers,
Adriaan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants