refactor: remove unnecessary string hashes #815
+101
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamirmahal
commented
Oct 6, 2024
tyt2y3
reviewed
Oct 7, 2024
tests/sqlite/query.rs
Outdated
Comment on lines
910
to
921
| r#"SELECT "aspect""#, | ||
| r#"FROM "glyph""#, | ||
| r#"WHERE IFNULL("aspect", 0) > 2"#, | ||
| r#"ORDER BY CASE"#, | ||
| r"ORDER BY CASE", | ||
| r#"WHEN "id"=4 THEN 0"#, | ||
| r#"WHEN "id"=5 THEN 1"#, | ||
| r#"WHEN "id"=1 THEN 2"#, | ||
| r#"WHEN "id"=3 THEN 3"#, | ||
| r#"ELSE 4 END,"#, | ||
| r"ELSE 4 END,", | ||
| r#""glyph"."aspect" ASC"#, | ||
| ] | ||
| .join(" ") |
There was a problem hiding this comment.
Thank you for the above changes.
While I think most removal are fine when they're clearly not necessary, this bits look inconsistent with the surrounding lines?
Can you revert the changes where it is in a vec of string and the other lines still need r#?
There was a problem hiding this comment.
You're welcome. I reverted the changes in specific spots to make it more consistent.
hamirmahal
force-pushed
the
refactor/remove-unnecessary-string-hashes
branch
from
9d464d8
to
dd86f38
Compare
in specific spots
hamirmahal
force-pushed
the
refactor/remove-unnecessary-string-hashes
branch
from
dd86f38
to
65deaee
Compare
tyt2y3
reviewed
Oct 7, 2024
tests/sqlite/table.rs
Outdated
There was a problem hiding this comment.
sorry I'd probably not change this file as well
There was a problem hiding this comment.
Okay, I reverted the changes to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
This change is backward compatible.
Changes