nodejs-lts: fix checkver and add arm64 version #5657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All changes look good. Wait for review from human collaborators. nodejs-lts
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. nodejs-lts
|
azrdn
changed the title
|
For what it's worth: I'm not sure how to review this, but I tested it by running this: scoop install https://raw.githubusercontent.com/ScoopInstaller/Main/0f5202c216bf79be81549880c86f33eef1218be9/bucket/nodejs-lts.json(that's the raw URL of the file in this PR) and it worked flawlessly on my computer. Thanks! |
|
Seeing how long it takes to for those PRs to get merged, we should change the checkver script to instead get the latest version from https://nodejs.org/dist/index.json to no longer be dependent on the layout of nodejs.org. |
|
/verify |
|
All changes look good. Wait for review from human collaborators. nodejs-lts
nodejs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the redesign of the Node.js website, the checkver of the nodejs-lts package is broken, this pull request fixes it, and also adds the arm64 version