-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Installation Guide #5416
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #5416 +/- ##
=======================================
Coverage 89.37% 89.37%
=======================================
Files 89 89
Lines 22443 22443
Branches 5381 5381
=======================================
Hits 20058 20058
Misses 1639 1639
Partials 746 746 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes absolutely, I think this is a worthy improvement !!
Thanks @rcomer
I'm eager to fix this, but it needs a rebase/merge to resolve conflicts. |
OK I rebased, but |
OK I might have misunderstood. Can't remember what it looked like, now ! It does appear that you need to resolve the conversation you opened - I can't do it. |
Thanks @rcomer, it's in ! |
Thanks @pp-mo! |
🚀 Pull Request
Description
The installation guide is now out of date in a couple of places:
pip
command in a new venv on my Ubuntu laptop and it Just Worked™.I've also changed the language we use to distinguish things.
I took the liberty of adding this to the v3.7.0 project as I think it would be nice to have this in the upcoming release's docs. Obviously boot it out again if you disagree.
Consult Iris pull request check list