removed redundant timeattr check and added tests to ensure datetime/c… #5396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ftime.datetime/partialdatetime play nicely.
trexfeathers
requested changes
Jul 28, 2023
There was a problem hiding this comment.
Thanks for looking into this @acchamber.
Some comments below, plus this needs a What's New entry.
added 2 commits
July 31, 2023 11:29
…o fix_for_#5175 * 'fix_for_#5175' of https://github.com/acchamber/iris: Added link to UDUNITS-2 database to convert_units docstrings (SciTools#5388)
trexfeathers
requested changes
Jul 31, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5396 +/- ##
==========================================
- Coverage 89.39% 89.39% -0.01%
==========================================
Files 89 89
Lines 22440 22436 -4
Branches 5382 5380 -2
==========================================
- Hits 20060 20056 -4
Misses 1635 1635
Partials 745 745
☔ View full report in Codecov by Sentry. |
trexfeathers
approved these changes
Jul 31, 2023
acchamber
added a commit
to acchamber/iris
that referenced
this pull request
Aug 7, 2023
…o fix_for_#5372 * 'fix_for_#5372' of https://github.com/acchamber/iris: [pre-commit.ci] pre-commit autoupdate (SciTools#5406) Avoid using deprecated ContourSet attributes (SciTools#5405) removed redundant timeattr check and added tests to ensure datetime/c… (SciTools#5396) Include location coordinates in the data variable coordinates attribute (SciTools#5389) Added link to UDUNITS-2 database to convert_units docstrings (SciTools#5388)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Solving #5175, this removes the restriction against comparing datetime objects, as the only ones Iris should deal with are datetime.datetime, cftime.datetime, and PartialDateTime. Adds various new tests for checking combinations of those act as they should.