Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call complete on systems generated in MTKExt #690

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

AayushSabharwal
Copy link
Member

MTKv9 requires systems to be completed before creating XProblems

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4693404) 8.78% compared to head (90ccc2a) 8.62%.

Files Patch % Lines
ext/OptimizationMTKExt.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #690      +/-   ##
=========================================
- Coverage    8.78%   8.62%   -0.16%     
=========================================
  Files          31      31              
  Lines        2515    2515              
=========================================
- Hits          221     217       -4     
- Misses       2294    2298       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 561699d into SciML:master Jan 30, 2024
39 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants