Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Keep symbolic expressions from mtk, make it moi compatible later #636

Merged
merged 7 commits into from
Dec 19, 2023

Conversation

Vaibhavdixit02
Copy link
Member

Checklist

  • [] Appropriate tests were added
  • [] Any code changes were done in a way that does not break public API
  • [] All documentation related to code changes were updated
  • [] The new code follows the
    contributor guidelines, in particular the ScioML Style Guide and
    COLPRAC.
  • [] Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 89 lines in your changes are missing coverage. Please review.

Comparison is base (6fc5804) 0.00% compared to head (75d197b) 7.47%.
Report is 1 commits behind head on master.

Files Patch % Lines
lib/OptimizationMOI/src/OptimizationMOI.jl 0.00% 49 Missing ⚠️
lib/OptimizationMOI/src/nlp.jl 0.00% 28 Missing ⚠️
lib/OptimizationMOI/src/moi.jl 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #636      +/-   ##
=========================================
+ Coverage    0.00%   7.47%   +7.47%     
=========================================
  Files          12      40      +28     
  Lines        1141    2730    +1589     
=========================================
+ Hits            0     204     +204     
- Misses       1141    2526    +1385     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vaibhavdixit02 Vaibhavdixit02 force-pushed the symbolicify branch 2 times, most recently from 13cd4e5 to e7f6e10 Compare December 17, 2023 04:53
@Vaibhavdixit02 Vaibhavdixit02 merged commit a99f82c into master Dec 19, 2023
24 of 26 checks passed
@Vaibhavdixit02 Vaibhavdixit02 deleted the symbolicify branch December 19, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant