diff --git a/NEWS.md b/NEWS.md index 123dfe15a..86cd981f7 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,9 +1,7 @@ # v4 Breaking changes -1. The main change in this breaking release has been the way mini-batching is handled. The data argument in the solve call and the implicit iteration of that in the callback has been removed, -the stochastic solvers (Optimisers.jl and Sophia) now handle it explicitly. You would now pass in a DataLoader to OptimizationProblem as the second argument to the objective etc (p) if you -want to do minibatching, else for full batch just pass in the full data. + 1. The main change in this breaking release has been the way mini-batching is handled. The data argument in the solve call and the implicit iteration of that in the callback has been removed, + the stochastic solvers (Optimisers.jl and Sophia) now handle it explicitly. You would now pass in a DataLoader to OptimizationProblem as the second argument to the objective etc (p) if you + want to do minibatching, else for full batch just pass in the full data. -2. The support for extra returns from objective function has been removed. Now the objective should only return a scalar loss value, hence callback doesn't take extra arguments other than the state and loss value. - - + 2. The support for extra returns from objective function has been removed. Now the objective should only return a scalar loss value, hence callback doesn't take extra arguments other than the state and loss value. diff --git a/docs/src/index.md b/docs/src/index.md index 95473e8e8..962cef388 100644 --- a/docs/src/index.md +++ b/docs/src/index.md @@ -171,9 +171,11 @@ to add the specific wrapper packages. - Unconstrained: ✅ ``` + 🟡 = supported in downstream library but not yet implemented in `Optimization.jl`; PR to add this functionality are welcome ## Citation + ``` @software{vaibhav_kumar_dixit_2023_7738525, author = {Vaibhav Kumar Dixit and Christopher Rackauckas}, @@ -185,37 +187,48 @@ to add the specific wrapper packages. url = {https://doi.org/10.5281/zenodo.7738525}, year = 2023} ``` + ## Reproducibility + ```@raw html
The documentation of this SciML package was built using these direct dependencies, ``` + ```@example using Pkg # hide Pkg.status() # hide ``` + ```@raw html
``` + ```@raw html
and using this machine and Julia version. ``` + ```@example using InteractiveUtils # hide versioninfo() # hide ``` + ```@raw html
``` + ```@raw html
A more complete overview of all dependencies and their versions is also provided. ``` + ```@example using Pkg # hide Pkg.status(; mode = PKGMODE_MANIFEST) # hide ``` + ```@raw html
``` + ```@eval using TOML using Markdown diff --git a/lib/OptimizationOptimJL/src/OptimizationOptimJL.jl b/lib/OptimizationOptimJL/src/OptimizationOptimJL.jl index 1a215739c..b2d6db4f8 100644 --- a/lib/OptimizationOptimJL/src/OptimizationOptimJL.jl +++ b/lib/OptimizationOptimJL/src/OptimizationOptimJL.jl @@ -292,7 +292,6 @@ function SciMLBase.__solve(cache::OptimizationCache{ else fg! = cache.f.fg end - gg = function (G, θ) cache.f.grad(G, θ)