feat: add Å to SI accepted units #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbliven
approved these changes
Oct 21, 2024
src/common/utils.ts
Outdated
| Unit.isValidAlpha = function (c) { | ||
| return isAlphaOriginal(c) || c == 'Å' | ||
| } | ||
| createUnit('Å', '1 angstrom') |
There was a problem hiding this comment.
This works since mathjs is only imported in a single file. However if we need to handle units from multiple files then we should refactor this so that the module setup code only gets called once.
|
I changed the title and ran the lint; everything should be in order now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Å as accepted mathjs unit, equivalent to angstrom
Motivation
Required for the correct interpretation of certain metadata, can be easily extended for other special character units.
Fixes:
Please provide a list of the fixes implemented by this PR
Changes:
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included