Fix config value from BE config #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minottic
force-pushed
the
be_config_fix
branch
from
df08654
to
2100e89
Compare
minottic
force-pushed
the
be_config_fix
branch
from
850e1c8
to
9b6006b
Compare
nitrosx
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix LoopBackConfig to take the correct field from the config
Motivation
The LoopBackConfig instantiation takes the wrong field from the config.
scicatBaseUrl is the FE URL. This is used, e.g., when needing to be redirected to the scicat FE on dataset click from within a publication detail page
lbBaseURL is the BE URL used for data querying
Fixes:
Changes:
Tests included/Docs Updated?
Extra Information/Screenshots