Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): add what's necessary for tests #369

Merged
merged 2 commits into from
Nov 9, 2023
Merged

feat(test): add what's necessary for tests #369

merged 2 commits into from
Nov 9, 2023

Conversation

Frzk
Copy link
Contributor

@Frzk Frzk commented Nov 9, 2023 •
edited
Loading

Add a few things required to include tests in a near future:

  • a Makefile that allows to launch tests locally (make test)
  • a GitHub Action that will run the tests when opening a Pull Request
  • a test/shunit2 file, which is the binary of shUnit2
  • a test/run file to launch the tests
  • a test/tests file that contains the tests.

Two dummy tests have been added:

  • one that should pass,
  • and one that should fail (and we'll have to fix it to pass the CI)

@Frzk Frzk self-assigned this Nov 9, 2023
@Frzk Frzk requested a review from Soulou November 9, 2023 14:18
Soulou
Soulou approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@Soulou Soulou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great \o/

Let's fix the test and merge that then?

@Frzk Frzk requested a review from Soulou November 9, 2023 14:37
@Soulou Soulou merged commit 8da1e49 into master Nov 9, 2023
2 checks passed
@Soulou Soulou deleted the feat/364/testing branch November 9, 2023 14:50
@Frzk Frzk mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soulou Soulou Awaiting requested review from Soulou

Assignees

@Frzk Frzk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Frzk @Soulou