Let user override site.conf

[johnsudaar]

For some advanced usage, we might want to override the default site.conf file. (i.e: to change the fastcgi_read_timeout).

A nice solution would be to support extra.paas.nginx_override_site_conf option that will replace our site.conf with the one the user provider us.

[EtienneM]

Isn't it what .extra.paas.nginx-includes allows?

[johnsudaar]

No because nginx-include will be included IN the site.conf (base.conf.erb in the file). However sometime we want to change the default configuration that is made in this base.conf.erb file.

[EtienneM]

To make sure I understand what you mean, you want to let the user customize this line:

https://github.com/Scalingo/php-buildpack/blob/8ecae1a66dbaa9dfb127db716ad40f2965f6727c/conf/nginx/base.conf.erb

Is that it?

[johnsudaar]

This entire file yes not a specific line.