Update ch-1 new version V3 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianalarcon
reviewed
Oct 9, 2024
There was a problem hiding this comment.
I think this file is already here on a different folder, no need it again
.github/workflows/main.yml
Outdated
| @@ -49,17 +49,6 @@ jobs: | |||
| run: yarn install --immutable | |||
| working-directory: ./packages/nextjs | |||
|
|
|||
| - name: Check Code Format | |||
There was a problem hiding this comment.
We will need these actions. I think we dont need to delete them
packages/nextjs/hooks/scaffold-stark/__tests__/useAutoConnect.test.ts
Outdated
Show resolved
Hide resolved
|
|
|
yarn test not working
|
ngjupeng
reviewed
Oct 11, 2024
|
@Nadai2010 can update this bug |
|
Yes, i update today |
…foldWriteContracts and useScaffoldReadContracts) add uodate de contract.ts
|
Hi, @metalboyrick, @jrcarlos2000, @ngjupeng I have added the changes to the hook in the PR329 and PR325. The challenger-1 is working, only need to resolve the checkSummer of the events. |
…d-Stark/speedrunstark into nadai/challenge-1-update
|
Fixed multiwrite with Scaffold PR 332: Scaffold-Stark#332 |
metalboyrick
merged commit 79d21a9
into
challenge-1-decentralized-staking
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ch-1 new version V3
This version is updated with the latest features from v3 and some improvements integrated into the OD Hack up to PR-316 of Scaffold Stark
Types of change
Comments (optional)
Cairo contracts are not optimized