Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dragons and adventurers endeavours complete early #1037

Open
SapiensAnatis opened this issue Aug 21, 2024 · 2 comments
Open

Upgrade dragons and adventurers endeavours complete early #1037

SapiensAnatis opened this issue Aug 21, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@SapiensAnatis
Copy link
Owner

Describe the bug

Both "Raise a water attunned adventurer to level 30" and "Upgrade a water attuned dragon to level 5" endeavors completed without having actually done them.

With an inventory of level 1 dragons and a few adventurers at level 8, the endeavours were completed.

Expected behavior
They should complete according to the description

@SapiensAnatis SapiensAnatis added the bug Something isn't working label Aug 21, 2024
@SapiensAnatis
Copy link
Owner Author

This is probably a mismatch between the _CompleteValue and how we calculate initial progress.

For example, royal regimen mission 104400 "Upgrade a Light-Attuned Dragon to Lv. 30" is insta-completed on a fresh account that has not met the requirements. This looks to be because in GetInitialMissionProgress we call GetDragonMaxLevel and get a value of 1, but the _CompleteValue is 1 (signifying 1 dragon at level 30?), so we view the mission as completed.

@SapiensAnatis
Copy link
Owner Author

SapiensAnatis commented Oct 10, 2024

Offending missions:

Text _CompleteValue
Raise a Water-Attuned Adventurer to Lv. 30 1
Upgrade a Water-Attuned Dragon to Lv. 5 1
Upgrade a Flame-Attuned Dragon to Lv. 10 1
Raise a Shadow-Attuned Adventurer to Lv. 40 1
Raise a Light-Attuned Adventurer to Lv. 50 1
Upgrade a Light-Attuned Dragon to Lv. 30 1
Upgrade a Shadow-Attuned Dragon to Lv. 30 1
Raise a Flame-Attuned Adventurer to Lv. 70 1
Raise a Shadow-Attuned Adventurer to Lv. 70 1
Raise a Wind-Attuned Adventurer to Lv. 70 1
Raise a Water-Attuned Adventurer to Lv. 70 1
Raise a Light-Attuned Adventurer to Lv. 70 1
Upgrade a Dragon to Lv. 50 50
Raise an Adventurer to Lv. 80 80
Upgrade a Dragon to Lv. 80 80

Frustratingly our current calculation is correct for the last three so we can't just change GetDragonMaxLevel to return the number satisfying the threshold. We will probably have to introduce a new MissionCompleteType.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant