New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparison warning with COLL_SIZE_CROSSOVER #899

Closed

davidozog opened this issue Nov 14, 2019 · 1 comment

Member

davidozog commented Nov 14, 2019

In file included from collectives_c.c:31:
../../src/shmem_collectives.h:187:39: warning: comparison of integers of different signs: 'int' and 'shmem_internal_env_size' (aka 'unsigned long') [-Wsign-compare]
                if (count * type_size < shmem_internal_params.COLL_SIZE_CROSSOVER)
                    ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This came up during the review of the teams API.

It seems like we might want to convert count and type_size from int's to size_t's.

The text was updated successfully, but these errors were encountered:

Member

jdinan commented Nov 18, 2019

Resolved by #886

jdinan closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment