Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeywordPattern regex improvement #606

Merged
merged 4 commits into from
Sep 16, 2024
Merged

KeywordPattern regex improvement #606

merged 4 commits into from
Sep 16, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Sep 9, 2024

Description

Please include a summary of the change and which is fixed.

part of #600

  • KeywordPattern extracted to separated file and regex refactored (some of cases were not covered yet - keep todo in test)
  • Tests refactoring get_line_data
  • AWS Multi reduce pattern to 35 auxiliary secret - CredData markup

How has this been tested?

Please describe the tests that you ran to verify your changes.

@babenek babenek changed the title part of changes KeywordPattern regex improvement Sep 9, 2024
@babenek babenek marked this pull request as ready for review September 9, 2024 10:57
@babenek babenek requested a review from a team as a code owner September 9, 2024 10:57
@@ -22,7 +22,8 @@ jobs:
- name: Checkout CredData
uses: actions/checkout@v4
with:
repository: Samsung/CredData
repository: babenek/CredData
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be rollback in #600 after merge conflicts an so on...

@babenek babenek merged commit a73faaa into Samsung:main Sep 16, 2024
27 checks passed
@babenek babenek deleted the filterim branch September 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants