Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command line patterns #605

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Command line patterns #605

merged 3 commits into from
Sep 9, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Sep 9, 2024 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Add command line patterns with future ML usage
  • BM scores are temporally and applied only for passed the workflow - welcome to review Corrections CredData#167

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek marked this pull request as ready for review September 9, 2024 07:04
@babenek babenek requested a review from a team as a code owner September 9, 2024 07:04
csh519
csh519 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New rules are added for command line credentials.

LGTM 👍

Yullia
Yullia approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek merged commit 2534b92 into Samsung:main Sep 9, 2024
27 checks passed
@babenek babenek deleted the ConvertTo-SecureString-pattern branch September 9, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yullia Yullia Yullia approved these changes

@csh519 csh519 csh519 approved these changes

@xDizzix xDizzix Awaiting requested review from xDizzix

@iuriimet iuriimet Awaiting requested review from iuriimet

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @Yullia @csh519