Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValuePathFilter and keyword regex enchancement #595

Merged
merged 12 commits into from
Aug 13, 2024
Merged

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Aug 11, 2024

Description

Please include a summary of the change and which is fixed.

  • Add square brackets in keyword regex to detect a list definition
  • Add case when keyword is in protocol name and followed URL is obtained like a variable with semicolon as delimiter authp://some.url
  • case of TOML definitions

How has this been tested?

Please describe the tests that you ran to verify your changes.

@babenek babenek marked this pull request as ready for review August 13, 2024 06:48
@babenek babenek requested a review from a team as a code owner August 13, 2024 06:48
Copy link
Contributor

@xDizzix xDizzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@babenek babenek merged commit 45e0643 into Samsung:main Aug 13, 2024
27 checks passed
@babenek babenek deleted the auxiliary branch August 13, 2024 15:35
@babenek babenek restored the auxiliary branch August 13, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants