Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip ml_validator creation when no credentials found #389

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Skip ml_validator creation when no credentials found #389

merged 1 commit into from
Jul 27, 2023

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jul 26, 2023 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Add log when ml validation is disabled
  • skip ml_validator creation when no candidates were found

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest

@babenek babenek marked this pull request as ready for review July 26, 2023 13:36
@babenek babenek requested a review from a team as a code owner July 26, 2023 13:36
xDizzix
xDizzix approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@xDizzix xDizzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More logging to a logging GOD

csh519
csh519 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can help improvement of performance.

LGTM 👍

@babenek babenek merged commit 6579b1d into Samsung:main Jul 27, 2023
24 checks passed
@babenek babenek deleted the auxiliary branch July 27, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDizzix xDizzix xDizzix approved these changes

@csh519 csh519 csh519 approved these changes

@Yullia Yullia Awaiting requested review from Yullia

@iuriimet iuriimet Awaiting requested review from iuriimet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @xDizzix @csh519