Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slight changes #382

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Slight changes #382

merged 8 commits into from
Jul 19, 2023

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jul 18, 2023 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • system resources measurement for benchmark workflow
  • value_lower for line_data to reduce lower() invocation
  • some light changes to reduce next PR complexity

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark performance

@babenek babenek marked this pull request as ready for review July 18, 2023 12:35
@babenek babenek requested a review from a team as a code owner July 18, 2023 12:35
@babenek babenek mentioned this pull request Jul 18, 2023
Merged
3 tasks
csh519
csh519 reviewed Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all.. I wonder is it really needed to reduce the memory usage of CredSweeper now..
IMO old structure looks better to maintain.
Could you explain why this PR is needed?

credsweeper/credentials/candidate.py Show resolved Hide resolved
csh519
csh519 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the first step of memory reduction.

LGTM 👍

@babenek babenek merged commit 3989a25 into Samsung:main Jul 19, 2023
24 checks passed
@babenek babenek deleted the auxiliary branch July 19, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuriimet iuriimet iuriimet approved these changes

@csh519 csh519 csh519 approved these changes

@xDizzix xDizzix Awaiting requested review from xDizzix

@Yullia Yullia Awaiting requested review from Yullia

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @iuriimet @csh519