Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEM scanner refactoring #373

Merged
merged 2 commits into from
Jul 4, 2023
Merged

PEM scanner refactoring #373

merged 2 commits into from
Jul 4, 2023

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jul 1, 2023 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Applied forgotten ValuePemPatternCheck for PEM scanner
  • refactored PEM detector
  • morphemes list updatet with VoC
  • Add all lines of PEM to line_data_list

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Test Benchmark

@babenek babenek changed the title Multiline PEM scanner refactoring Jul 3, 2023
@babenek babenek mentioned this pull request Jul 3, 2023
Closed
2 tasks
@babenek babenek marked this pull request as ready for review July 3, 2023 19:49
@babenek babenek requested a review from a team as a code owner July 3, 2023 19:49
@babenek babenek mentioned this pull request Jul 4, 2023
Merged
1 task
@babenek babenek requested a review from csh519 July 4, 2023 06:08
csh519
csh519 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for refactor PEM scanner.

LGTM 👍

@babenek babenek merged commit b1120b9 into Samsung:main Jul 4, 2023
24 checks passed
@babenek babenek deleted the multiline branch July 4, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuriimet iuriimet iuriimet approved these changes

@csh519 csh519 csh519 approved these changes

@xDizzix xDizzix Awaiting requested review from xDizzix

@Yullia Yullia Awaiting requested review from Yullia

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @iuriimet @csh519