Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Server Side Rendering (SSR) #1509

Open
robines opened this issue Oct 3, 2024 · 3 comments
Open

Implement Server Side Rendering (SSR) #1509

robines opened this issue Oct 3, 2024 · 3 comments
Assignees
Labels
WFR Wait For Relevancy

Comments

@robines
Copy link
Member

robines commented Oct 3, 2024

Having some form of Server Sider Rendering (SSR) is an absolute requirement for the project. We need it for SEO and to use Open Graph meta tags (for sharing on social media).

Our current stack does not support SSR very well, but luckily for us, major changes are coming in the next version of React Router (v7), which seemingly makes adding SSR a breeze. See this video from React Conf, demoing the RR v7 SSR functionality.

Sadly there is no release date set for v7 yet, so we can't just sit and wait until it releases. From the linked comment:

The recommendation is to use Remix v2 if you plan to use RRv7 as RRv7 will be similar to Remix v2 with the future flags enabled.

Further reading:

Edit: Put on hold for now, since it's not necessary for launching the recruitment system

@robines robines added the blocked Blocked by another issue. label Oct 3, 2024
@robines robines self-assigned this Oct 3, 2024
@robines robines removed the blocked Blocked by another issue. label Oct 3, 2024
@Frenje123 Frenje123 changed the title Implement SSR Implement Server Side Rendering (SSR) Oct 8, 2024
@robines robines added the WFR Wait For Relevancy label Oct 8, 2024
@emilte
Copy link
Member

emilte commented Oct 11, 2024

Absolute requirement? Er det det?
Det blir et helt annet type prosjekt

@robines
Copy link
Member Author

robines commented Oct 12, 2024

@emilte Ja, det er det. Vi kan ikke launche en ny nettside som ikke dukker opp ordentlig på Google, eller som ikke får opp bilde og tittel på arrangementer når man deler de på sosiale medier. Da vil vi raskt bli bedt om å bytte tilbake til Samf3 til det blir fikset.

Ser ikke hvordan det blir et helt annet prosjekt? Med RR v7 vil vi forhåpentligvis kunne veldig enkelt enable SSR på enkelte sider, feks. forsiden og arrangement-siden. Det som blir forskjellig er at man ikke da kan bare serve statiske filer for frontend, men det vil ikke ha noen reelle konsekvenser så det tenker jeg går fint.

@emilte
Copy link
Member

emilte commented Oct 15, 2024

Så lenge ITK er åpen for å kjøre det så. Tidligere synes jeg å huske at node/npm økosystem var utelukket på deres servere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WFR Wait For Relevancy
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants