Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelled requests stall the recording process #20

Open
Sam152 opened this issue Feb 17, 2023 · 2 comments
Open

Cancelled requests stall the recording process #20

Sam152 opened this issue Feb 17, 2023 · 2 comments

Comments

@Sam152
Copy link
Owner

Sam152 commented Feb 17, 2023

No description provided.

@martijn-w2w
Copy link

I ran into this issue as well. Fixing the issue using something provided by Cypress is obviously the preferred solution, but since that is currently not possible I created a quickfix to get around the issue: 1.0...martijn-w2w:cypress-replay:feature/quickfix-record-cancelled-requests. This quickfix works for the test you added in #21 but does require a change to the cypress timeout config.

Let me know if you're interested in it as a temporary solution, then I'll create a PR for it.

@Sam152
Copy link
Owner Author

Sam152 commented Feb 22, 2023

Nice solution! Perhaps a section in the readme with "Known issues" and this as a work-around? Not against adding it to the repo, but I have also reported the issue in the cypress repo, so potentially there is a resolution coming there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants