Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make research_VENUS.load_VENUS() fault tolerant #25

Open
douglatornell opened this issue Dec 11, 2015 · 0 comments
Open

Make research_VENUS.load_VENUS() fault tolerant #25

douglatornell opened this issue Dec 11, 2015 · 0 comments
Labels
bug Something isn't working minor SalishSeaNowcast

Comments

@douglatornell
Copy link
Member

Original report by Doug Latornell (Bitbucket: douglatornell, GitHub: douglatornell).


load_VENUS() uses request.get() without any re-try log. It almost always works (and is fine for notebook use), but when a ConnectionError occurs in the nowcast system's use case it stops the automation path to pushing the results to the web (happene on 11dec15).

Idea:

  • Split load_VENUS() to separate getting the data from the ONC web service and parsing it into a pandas dataframe.
  • Retain a load_VENUS() function that gets data from the web for use in notebooks.
  • Change compare_VENUS() to accept either a buffer containing the web data, or a pandas dataframe as an arg.
  • Do the data download using nowcast.lib.get_web_data() in make_plots._make_research_plots() and pass the data into compare_VENUS().

Need to think about/explore binary vs. text data handling as nowcast.lib.get_web_data() presently only handles binary (response.content).

@douglatornell douglatornell added minor SalishSeaNowcast bug Something isn't working labels Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor SalishSeaNowcast
Projects
None yet
Development

No branches or pull requests

1 participant