Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor atom input component 1 #2449

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

andresin87
Copy link
Member

@andresin87 andresin87 commented Oct 26, 2022

Atom/Input

❓ Ask

TASK:

Types of changes

  • πŸͺ² Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • πŸ“· Demo
  • πŸ§ͺ Test
  • 🧠 Refactor
  • πŸ’„ Styles

Description, Motivation and Context

The current AtomInput structure is giving problems with refs due to its HTML structure.

It also takes lots of improvements:

  • consistancy: mask and sui-password input types are able to work with icons and addons.
  • removes unnecesary wrappers.
  • avoid position absolutes.
  • removes an effortless giant mixin (performance)
  • updates imask

Screenshots - Animations

🚨🚨🚨🚨🚨🚨

This PR will remain iddle untill 1 person per vertical reviews its demo l&f and approves it at least.

Components which use @s-ui/react-atom-input or needs a review:

habitaclia milanuncios carfactory epreselect fotocasa motor infojobs Adevinta sui default
AtomInput ❌ βœ… βœ… βœ…
AtomTextArea βœ… βœ… βœ… βœ…
AtomTag βœ… βœ… βœ… βœ…
MoleculeAutosuggest βœ… βœ… βœ… βœ…
MoleculeAutosuggestField βœ… βœ… βœ… βœ…
MoleculeDataCounter βœ… βœ… βœ… βœ…
MoleculeDropdownList βœ… βœ… βœ… βœ…
MoleculeInputField βœ… βœ… βœ… βœ…
MoleculeInputTags βœ… βœ… βœ… βœ…
MoleculeSelect βœ… βœ… βœ… βœ…
All βœ… βœ… βœ… βœ…

Mark on each component when reviewing your branded components or just one mark at the end if everything is ok to confirm all the component changes:

  • βœ… if its ok
  • ❌ if it needs some fix

TEST on your vertical (if needed) installing:

@andresin87 andresin87 changed the base branch from refactor-atom-input-component to master October 26, 2022 13:19
@andresin87 andresin87 marked this pull request as ready for review October 26, 2022 13:21
@github-actions
Copy link

STATEMENTS BRANCHES FUNCTIONS LINES
≍ ≍ 0.08↑ ≍ 0.19↓ ≍ 0.25↑ ≍ 0.25↑
% 72.33 58.33 59.68 74.1
ABS 2680 / 3705 1533 / 2628 490 / 821 2584 / 3487

@@ -11,7 +11,7 @@
"dependencies": {
"@s-ui/react-hooks": "1",
"@s-ui/react-primitive-polymorphic-element": "1",
"imask": "3.4.0"
"react-imask": "6.4.3"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant