Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Main Infra check #917

Merged
merged 8 commits into from
Jul 3, 2023
Merged

PR - Main Infra check #917

merged 8 commits into from
Jul 3, 2023

Conversation

amankumarrr
Copy link
Member

@amankumarrr amankumarrr commented Jul 3, 2023

Fixes #897

Description:
Removing the duplicate name of workflows, added testing for the main's BICEP with the pull request, and fixing the Service Principal ID error with the flow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Deployed changes to https://app-sswwebsite-9eb3-pr-917.azurewebsites.net

@amankumarrr amankumarrr changed the title PR - main infra check PR - Main Infra check Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Deployed changes to https://app-sswwebsite-9eb3-pr-917.azurewebsites.net

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

PageSpeed Insights

Category Score
Accessibility 89
Best practices 92
Performance 60
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-917.azurewebsites.net

Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amankumarrr amankumarrr marked this pull request as ready for review July 3, 2023 04:40
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Deployed changes to https://app-sswwebsite-9eb3-pr-917.azurewebsites.net

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

PageSpeed Insights

Category Score
Accessibility 89
Best practices 83
Performance 61
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-917.azurewebsites.net

@amankumarrr amankumarrr merged commit 20c8450 into main Jul 3, 2023
10 checks passed
@amankumarrr amankumarrr deleted the pipeline-main-infra-check branch July 3, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 PR - Fix check to ensure main infra code works
3 participants