Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Redesign newsletter subscribe form #860

Merged
merged 9 commits into from
Jun 30, 2023
Merged

💄 Redesign newsletter subscribe form #860

merged 9 commits into from
Jun 30, 2023

Conversation

KristenHu
Copy link
Contributor

Fixes #707 - Reskin newsletter page as per Ken's design

Affected routes:

  • /newsletter

Add done video, screenshots
image

Kristen added 2 commits June 25, 2023 16:47
# Conflicts:
#	.tina/__generated__/_graphql.json
#	.tina/__generated__/_schema.json
#	components/blocks/newslettersTable.tsx
#	components/blocks/subNewsLetters.tsx
@KristenHu KristenHu marked this pull request as ready for review June 25, 2023 09:24
@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-860.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 89
Best practices 83
Performance 40
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-860.azurewebsites.net

Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Dark text on dark background doesnt work

components/blocks/subscribe.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-860.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 89
Best practices 92
Performance 57.99999999999999
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-860.azurewebsites.net

Comment on lines 122 to 125
className="mb-2 mt-6 text-center font-helvetica text-4xl font-medium text-sswBlack"
className="mb-2 mt-6 text-center font-helvetica text-4xl font-medium text-white"
dangerouslySetInnerHTML={{ __html: headerText }}
></h2>
<div className="mb-5 text-center text-base text-sswBlack">
<div className="mb-5 text-center text-base text-white">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

We need to conditionally change the text color depending on the background color

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done🙌
image

@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-860.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 89
Best practices 92
Performance 61
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-860.azurewebsites.net

@bradystroud bradystroud changed the title Newsletter page 💄 Redesign newsletter subscribe form Jun 30, 2023
@KristenHu KristenHu merged commit 164ea71 into main Jun 30, 2023
9 checks passed
@KristenHu KristenHu deleted the newsletterPage branch June 30, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💄Newsletter Page- styling
2 participants