Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnknown unicode character in Nick's name #3150

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

Calinator444
Copy link
Member

Description

There was a strange Unicode character in Nick's name. Removing the character so that this event still gets returned from the upcoming events endpoint.

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.22% 69/31203
🔴 Branches 7.57% 24/317
🔴 Functions 1.01% 3/296
🔴 Lines 0.22% 69/31203

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 4ada04c

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3150.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 64
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3150.azurewebsites.net

Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did it get there? Was it added by Tina?

@Calinator444
Copy link
Member Author

@bradystroud

How did it get there? Was it added by Tina?

Based on the commit history this character was added when Andrew ran the script to pull events from Tina. I'm a little confused as to why there was a broken Unicode character at that point in Nick's name though. It makes no sense.

@Calinator444 Calinator444 merged commit 57e742e into main Sep 23, 2024
11 checks passed
@Calinator444 Calinator444 deleted the fix-nick-name-ai-hack-day branch September 23, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants