Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗓️ Past Events - Fixed events endpoint #3124

Closed
wants to merge 1 commit into from

Conversation

Calinator444
Copy link
Member

@Calinator444 Calinator444 commented Sep 18, 2024

CC: @ncn-ssw

Description

The past events endpoint on the main site is failing due to an issue with Tina's cacheing system. I've disabled it on this branch to remedy the issue.

Copy link
Contributor

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@Calinator444 Calinator444 changed the title Added no cache parameter to tina build process 🚧 WIP - Added no cache parameter to tina build process Sep 18, 2024
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.22% 69/31180
🔴 Branches 7.59% 24/316
🔴 Functions 1.02% 3/295
🔴 Lines 0.22% 69/31180

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from b9ce681

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3124.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 64
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3124.azurewebsites.net

@Calinator444 Calinator444 changed the title 🚧 WIP - Added no cache parameter to tina build process 🗓️ Past Events - Fixed events endpoint Sep 18, 2024
@Calinator444
Copy link
Member Author

Closing this - As per my conversation with @wicksipedia we would prefer to fix the cached not being written correctly to our docker image than disable it entirely for better performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant