Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEMrush - Adding lang param & h1 for homepage #3034

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Conversation

amankumarrr
Copy link
Member

@amankumarrr amankumarrr commented Aug 27, 2024

Fixed #3037
Affected Route:

  • /
  • /*

Screenshot:
image

Figure: Website having lang tag along with h1 on the homepage

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.23% 69/30471
🔴 Branches 7.62% 24/315
🔴 Functions 1.02% 3/294
🔴 Lines 0.23% 69/30471

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from df4d26d

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3034.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 66
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3034.azurewebsites.net

@amankumarrr amankumarrr marked this pull request as ready for review August 28, 2024 00:33
Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image
Figure: HTML lang is there now 🙂

@amankumarrr amankumarrr merged commit eff221f into main Aug 28, 2024
11 checks passed
@amankumarrr amankumarrr deleted the semrush-lang branch August 28, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💸 SEMrush - Add lang tag & h1 on homepage
2 participants