-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄Megamenu - Update Megamenu contrast #3021
Conversation
Deployed changes to https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net |
This reverts commit 385db59.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tests are failing though
Coverage report
Test suite run success13 tests passing in 1 suite. Report generated by 🧪jest coverage report action from 694f544 |
I managed to fix the tests in the pipeline by manually downgrading @babel/parser to v7.21.9 Newer versions of babel won't have this issue so I'd keep an eye out for the next release |
Deployed changes to https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net |
Deployed changes to https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net |
Deployed changes to https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net |
Description
Updating the SSW Mega menu dependency on the website so that Issue #1751 can be closed off
Affected routes: ssw.com.au/*
Fixed 💄 UI - Mega Menu hover effect needs improvements #1751
- [ ] If adding a new page, I have followed the 📃 New Webpage issue templateScreenshot
Figure: Updated megamenu hover effect
Figure: New hover effect for search icon