Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄Megamenu - Update Megamenu contrast #3021

Merged
merged 24 commits into from
Sep 4, 2024
Merged

Conversation

Calinator444
Copy link
Member

@Calinator444 Calinator444 commented Aug 26, 2024

Description

Updating the SSW Mega menu dependency on the website so that Issue #1751 can be closed off

- [ ] If adding a new page, I have followed the 📃 New Webpage issue template

  • Include done video or screenshots

Screenshot

updated megamenu links

Figure: Updated megamenu hover effect

search icon hover effect

Figure: New hover effect for search icon

@Calinator444 Calinator444 changed the title 1751 update megamenu 💄Megamenu - Update Megamenu contrast Aug 26, 2024
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 92
Best practices 96
Performance 62
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net

Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
tests are failing though

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.23% 69/30471
🔴 Branches 7.62% 24/315
🔴 Functions 1.02% 3/294
🔴 Lines 0.23% 69/30471

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 694f544

@Calinator444
Copy link
Member Author

I managed to fix the tests in the pipeline by manually downgrading @babel/parser to v7.21.9

babel/babel#16754 (comment)

Newer versions of babel won't have this issue so I'd keep an eye out for the next release

babel/babel#16781

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 65
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net

@Calinator444
Copy link
Member Author

I sent a couple of requests on the staging URL to double check that were still getting logs after I upgraded app insights

image
Figure: Test request logged in app insights

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net

Copy link
Contributor

github-actions bot commented Sep 2, 2024

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 62
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net

Copy link
Contributor

github-actions bot commented Sep 4, 2024

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 61
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3021.azurewebsites.net

@Calinator444 Calinator444 merged commit 037e41d into main Sep 4, 2024
11 checks passed
@Calinator444 Calinator444 deleted the 1751-update-megamenu branch September 4, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💄 UI - Mega Menu hover effect needs improvements
3 participants