Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter - Replace image with new version #2349

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

bradystroud
Copy link
Member

@bradystroud bradystroud commented Mar 21, 2024

fixes #2350

  • Affected routes:
    /images/newsletter-uploads/2024/_2024_03__.NET%20Migrations%20Made%20Easy__.html

I had to rename it because of the tina bug tinacms/tinacms#3820

Penny asked me to update the image
@bradystroud bradystroud enabled auto-merge (squash) March 21, 2024 12:17
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.25% 69/27520
🔴 Branches 8.89% 24/270
🔴 Functions 1.2% 3/249
🔴 Lines 0.25% 69/27520

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 7d4e3c6

@bradystroud bradystroud linked an issue Mar 21, 2024 that may be closed by this pull request
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2349.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 30
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2349.azurewebsites.net

Copy link
Member

@amankumarrr amankumarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bradystroud bradystroud merged commit 1f79878 into main Apr 5, 2024
11 checks passed
@bradystroud bradystroud deleted the update-newsletter-image branch April 5, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📄 Swap march newsletter image
2 participants