Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo - Adding FireBootCamp page #2324

Merged
merged 10 commits into from
Mar 19, 2024
Merged

Logo - Adding FireBootCamp page #2324

merged 10 commits into from
Mar 19, 2024

Conversation

amankumarrr
Copy link
Member

@amankumarrr amankumarrr commented Mar 19, 2024 •
edited
Loading

Affected Route: /logo/firebootcamp
Fixed: #2278

Screenshot:
image

Figure: Logo - Firebootcamp page

@amankumarrr
Logo - Adding FireBootCamp page
393be4e 
Affected Route: `/logo/firebootcamp`
Fixed: #2278

Screenshot: TODO
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements 0.25% 69/27513
🔴 Branches 8.89% 24/270
🔴 Functions 1.2% 3/249
🔴 Lines 0.25% 69/27513

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 04479ea

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2324.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 38
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2324.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2324.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 32
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2324.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2324.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 34
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2324.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2324.azurewebsites.net

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2324.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 49
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2324.azurewebsites.net

@Harry-Ross Harry-Ross self-requested a review March 19, 2024 03:08
Harry-Ross
Harry-Ross reviewed Mar 19, 2024
View reviewed changes
components/util/constants.tsx Outdated Show resolved Hide resolved
components/blocks/fixedColumns.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2324.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 32
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2324.azurewebsites.net

Harry-Ross
Harry-Ross approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@Harry-Ross Harry-Ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚣‍♂️

@amankumarrr amankumarrr merged commit 70397df into main Mar 19, 2024
11 checks passed
@amankumarrr amankumarrr deleted the 2278-firebootcamp branch March 19, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harry-Ross Harry-Ross Harry-Ross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📄Migration | Logo | FBC page
2 participants
@amankumarrr @Harry-Ross