Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra security video to landing page + improved Benefits card #2263

Merged
merged 8 commits into from
Mar 14, 2024

Conversation

tiagov8
Copy link
Member

@tiagov8 tiagov8 commented Mar 11, 2024

cc @matt-goldman

Requested by @adamcogan : Re: Enterprise IT Security Consulting and Auditing

@tiagov8 tiagov8 changed the title Added extra security video to landing page Added extra security video to landing page + improved Benefits card Mar 11, 2024
Copy link
Contributor

github-actions bot commented Mar 11, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.25% 69/27094
🔴 Branches 8.92% 24/269
🔴 Functions 1.21% 3/248
🔴 Lines 0.25% 69/27094

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 981cf91

@tiagov8
Copy link
Member Author

tiagov8 commented Mar 11, 2024

Note: With the Benefits card change, the goal is to avoid this missalignment caused by inconsistent list in the content for the 1st card:

Screenshot 2024-03-11 at 3 07 46 PM

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2263.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 30
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2263.azurewebsites.net

@matt-goldman
Copy link

@tiagov8

Can we change:

Azure AD B2C

to:
Microsoft Entra ID

image

@tiagov8
Copy link
Member Author

tiagov8 commented Mar 13, 2024

@tiagov8

Can we change:

Azure AD B2C

to: Microsoft Entra ID

image

done

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2263.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 84
Best practices 96
Performance 57.99999999999999
SEO 76

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2263.azurewebsites.net

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2263.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 33
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2263.azurewebsites.net

Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@matt-goldman matt-goldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tiagov8

Approved - although I note Adam's email says

  1. Embed this video before mine

So he may ask you to change it

@tiagov8
Copy link
Member Author

tiagov8 commented Mar 14, 2024

Hi @tiagov8

Approved - although I note Adam's email says

  1. Embed this video before mine

So he may ask you to change it

Hi Matt, see the reasons I changed the position in the email: "Re: Enterprise IT Security Consulting and Auditing"

@tiagov8 tiagov8 merged commit c532400 into main Mar 14, 2024
11 checks passed
@tiagov8 tiagov8 deleted the add-secutiry-video branch March 14, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants