Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 UI - Simplifying tailwind.config.js + styles.css #2226

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

Harry-Ross
Copy link
Contributor

@Harry-Ross Harry-Ross commented Mar 1, 2024

  • Made prose styles more consistent across pages
    • Removed a lot of custom overrides for @tailwindcss/typography to simplify new dev experience, and align to the reasonable defaults intended by the use of the prose class
    • Condensed number of prose overrides, as employment and consulting were the same

image
Figure: / before

image
Figure: / after

image
Figure: /terms-and-conditions before

image
Figure: /terms-and-conditions after

image
Figure: /offices/hangzhou before

image
Figure: `/offices/hangzhou after

image
Figure: /industry/educational before

image
Figure: /industry/educational after

image
Figure: /consulting/angular before

image
Figure: /consulting/angular after (neglible change here)

@Harry-Ross Harry-Ross marked this pull request as draft March 1, 2024 06:39
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.26% 69/26098
🔴 Branches 9.3% 24/258
🔴 Functions 1.27% 3/237
🔴 Lines 0.26% 69/26098

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from df23a2f

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2226.azurewebsites.net

Copy link
Contributor

github-actions bot commented Mar 1, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 31
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2226.azurewebsites.net

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2226.azurewebsites.net

Copy link
Contributor

github-actions bot commented Mar 4, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 40
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2226.azurewebsites.net

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2226.azurewebsites.net

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2226.azurewebsites.net

@Harry-Ross Harry-Ross marked this pull request as ready for review March 5, 2024 01:06
Copy link
Contributor

github-actions bot commented Mar 5, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 28.000000000000004
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2226.azurewebsites.net

@Harry-Ross Harry-Ross merged commit 44b0f32 into main Mar 6, 2024
11 checks passed
@Harry-Ross Harry-Ross deleted the 804-heading-sizes branch March 6, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💸 UI Tech Debt - CSS - Headings sizes are not ideal
2 participants