Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄UI - Updating typography as per Boostraps' typography #1999

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

amankumarrr
Copy link
Member

@amankumarrr amankumarrr commented Jan 5, 2024

Fixed #1473

Affected Route: /*

  • /privacy

  • Include done video or screenshots

Before After
h1
font-weight
300 500
margin-bottom
18px 0.5rem
h2
font-size
18px 2rem
line-height
27px 2.4rem
margin-bottom
11.25px 0.5rem
font-weight
300 500
h3
font-weight
300 500
margin-bottom
7px 0.5rem
line-height
36px 2.1rem
font-size
22.5px 1.75rem
h4
font-weight
600 500
line-height
33.75px 1.8rem
margin-bottom
11.25px 0.5rem
font-size
22.5px 1.5rem

Screenshot
image

Figure: Privacy page after changing the typography's changes

Copy link
Contributor

github-actions bot commented Jan 7, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-1999.azurewebsites.net

Copy link
Contributor

github-actions bot commented Jan 7, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 95
Performance 27
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1999.azurewebsites.net

@amankumarrr amankumarrr marked this pull request as ready for review January 7, 2024 23:38
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-1999.azurewebsites.net

Copy link
Contributor

github-actions bot commented Jan 8, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 95
Performance 37
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1999.azurewebsites.net

@tiagov8 tiagov8 merged commit 3a43841 into main Jan 8, 2024
10 checks passed
@tiagov8 tiagov8 deleted the 1473-css-ui-weird-content branch January 8, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💸 CSS UI - Heading for content pages are weird
2 participants